Deduplicate when adding new elements to unique list

rails · Dec 3, 2021 · d5857e3 · d5857e3
1 parent e326fc3
commit d5857e3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/kredis/types/unique_list.rb b/lib/kredis/types/unique_list.rb
@@ -5,19 +5,25 @@ class Kredis::Types::UniqueList < Kredis::Types::List
   attr_accessor :typed, :limit
 
   def prepend(elements)
+    elements = Array(elements).flatten.uniq
+    return if elements.empty?
+
     multi do
       remove elements
       super
       ltrim 0, (limit - 1) if limit
-    end if Array(elements).flatten.any?
+    end
   end
 
   def append(elements)
+    elements = Array(elements).flatten.uniq
+    return if elements.empty?
+
     multi do
       remove elements
       super
       ltrim -limit, -1 if limit
-    end if Array(elements).flatten.any?
+    end
   end
   alias << append
 end
diff --git a/test/types/unique_list_test.rb b/test/types/unique_list_test.rb
@@ -63,4 +63,14 @@ class UniqueListTest < ActiveSupport::TestCase
     @list.prepend(%w[ 6 7 8 ])
     assert_equal %w[ 8 7 6 5 4 ], @list.elements
   end
+
+  test "appending array with duplicates" do
+    @list.append(%w[ 1 1 1 ])
+    assert_equal %w[ 1 ], @list.elements
+  end
+
+  test "prepending array with duplicates" do
+    @list.prepend(%w[ 1 1 1 ])
+    assert_equal %w[ 1 ], @list.elements
+  end
 end