Warn on missing asset in compiler #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenogazzola
force-pushed
the
ignore-missing
branch
from
e2e40d9
to
0d9a03a
Compare
|
Kinda thinking that in this case it's probably better to let the original url() go through because then you'll create a proper 404 as well. That's different from source maps because those are optional. If someone is referring to url() in css and the asset isn't there, things are broken. |
brenogazzola
force-pushed
the
ignore-missing
branch
from
0d9a03a
to
3c7d97b
Compare
|
Sorry, I misunderstood what you meant. Adjusted to preserve the original url. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an asset cannot be found when processing a CSS file, warn and replace with
url('')instead of raising.I did a quick test and the empty url does not seem to generate any extra network requests.