-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to upgrade guide #81
Conversation
Assuming all else is ok with these changes, I will wait till #79 is merged and integrate change with this, then open the PR. |
It's merged. |
Great, I will get on this today |
Minor changes to language/readability and an extra note about migrating webpack configuration before deleting
@stevegeek Do you still want to add anything or can I merge this? |
@brenogazzola Feel free to merge, Im happy with these changes for now, if I notice anything else in future I will open a new PR. |
Great! Thanks a lot for helping with the guide. |
@brenogazzola you are welcome! |
Hi all, here are some suggested edits and additions for the upgrade documentation.
I decided on these by running through the steps starting with a fresh Rails app (generated with 6.1 then upgraded to 7)
I started with
webpacker
andsass-rails
and tested the original steps. From that I noted something extra in relation to the default module resolution in webpacker and added a section about it.I then also ran through a setup where CSS was built by webpacker (
extract_css: true
). The additional instructions didn't seem to me to warrant a separate guide so I simply modified the main one.Happy to add/remove/modify anything as needed!
(Note the comment I made on the #76 about an error when removing webpacker was my bad)