Peg rails dependency to 4.0.0

[tiegz]

WHAT

• Set rails in gem to at least 4.0.0
• Also fix some deprecation warnings in the tests

WHY

bundle didn't work for me when I initially checked out the gem:

Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    rails (>= 0) ruby depends on
      activerecord (= 4.1.0.beta) ruby

    activerecord (4.0.0.rc1)

Could not find gem 'activerecord-deprecated_finders (~> 0.0.3) ruby', which is required by gem 'activerecord (~> 4.0.0.beta) ruby', in any of the sources.

Now that 4.0.0 we might as well point to that. After I did this, I get one failing test in SaveFromAfterCommitBlockTest#test_after_commit_in_save, but I'm not sure if it existed before these commits? (can't find travis build)

[sikachu]

I believe you can remove this line altogether.

[tiegz]

ah, thx! will do

[tiegz]

@rafaelfranca the test failure I'm getting is:

rails-observers/test/transaction_callbacks_test.rb

Line 275 in 3f4b626

assert_equal true, topic.cached

  1) Failure:
SaveFromAfterCommitBlockTest#test_after_commit_in_save [test/transaction_callbacks_test.rb:275]:
Expected: true
  Actual: false

This test broke in the switch from 4.0.0.beta1 to 4.0.0 (the test originated at rails/rails@44d1804)

I can't figure out what changed, but I'm also not sure why that test file is in rails-observers. Is it ok to remove it and/or return it to rails?

[rafaelfranca]

I need to take a look better on this one. Will do later

[guilleiguaran]

Oops, didn't noticed this and I fixed rake test, still getting the failing test mentioned here and some deprecation warnings.

Can you update this to handle only the deprecation warnings?

[guilleiguaran]

Deprecation warnings fixed, thanks for your contribution!!!

[guilleiguaran]

btw, the test still failing 😁