fix time typcasting on group counts in PG

rails · Dec 29, 2012 · 160af90 · 160af90
1 parent 8faf2b3
commit 160af90
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
@@ -274,7 +274,7 @@ def execute_grouped_calculation(operation, column_name, distinct) #:nodoc:
         column_alias_for(field)
       }
       group_columns = group_aliases.zip(group_fields).map { |aliaz,field|
-        [aliaz, column_for(field)]
+        [aliaz, field]
       }
 
       group = group_fields
@@ -314,7 +314,10 @@ def execute_grouped_calculation(operation, column_name, distinct) #:nodoc:
       end
 
       Hash[calculated_data.map do |row|
-        key = group_columns.map { |aliaz, column|
+        key = group_columns.map { |aliaz, column_name|
+          column = calculated_data.column_types.fetch(aliaz) do
+            column_for(column_name)
+          end
           type_cast_calculated_value(row[aliaz], column)
         }
         key = key.first if key.size == 1

diff --git a/activerecord/test/cases/adapters/postgresql/timestamp_test.rb b/activerecord/test/cases/adapters/postgresql/timestamp_test.rb
@@ -2,6 +2,12 @@
 require 'models/developer'
 
 class TimestampTest < ActiveRecord::TestCase
+  def test_group_by_date
+    keys = Topic.group("date_trunc('month', created_at)").count.keys
+    assert_operator keys.length, :>, 0
+    keys.each { |k| assert_kind_of Time, k }
+  end
+
   def test_load_infinity_and_beyond
     unless current_adapter?(:PostgreSQLAdapter)
       return skip("only tested on postgresql")