Remove convenience class alias

This convenience class is only used twice in Arel. We can easily write it out instead.
rails · Mar 13, 2020 · 166aee8 · 166aee8
1 parent 0c715e5
commit 166aee8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/activerecord/lib/arel.rb b/activerecord/lib/arel.rb
@@ -43,7 +43,7 @@ def self.star # :nodoc:
   end
 
   def self.arel_node?(value) # :nodoc:
-    value.is_a?(Arel::Node) || value.is_a?(Arel::Attribute) || value.is_a?(Arel::Nodes::SqlLiteral)
+    value.is_a?(Arel::Nodes::Node) || value.is_a?(Arel::Attribute) || value.is_a?(Arel::Nodes::SqlLiteral)
   end
 
   def self.fetch_attribute(value, &block) # :nodoc:
@@ -59,7 +59,4 @@ def self.fetch_attribute(value, &block) # :nodoc:
       fetch_attribute(value.expr, &block)
     end
   end
-
-  ## Convenience Alias
-  Node = Arel::Nodes::Node # :nodoc:
 end
diff --git a/activerecord/test/cases/arel/nodes/node_test.rb b/activerecord/test/cases/arel/nodes/node_test.rb
@@ -5,7 +5,7 @@
 module Arel
   class TestNode < Arel::Test
     def test_includes_factory_methods
-      assert Node.new.respond_to?(:create_join)
+      assert Arel::Nodes::Node.new.respond_to?(:create_join)
     end
 
     def test_all_nodes_are_nodes