Skip to content

Commit

Permalink
failing test for reorder overriding default_scope
Browse files Browse the repository at this point in the history
[5528]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  • Loading branch information
nragaz authored and spastorino committed Sep 5, 2010
1 parent 91fec0d commit 16e078d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions activerecord/test/cases/relation_scoping_test.rb
Expand Up @@ -390,6 +390,12 @@ def test_reorder_overrides_default_scope_order
assert_equal expected, received assert_equal expected, received
end end


def test_reordered_scope_overrides_default_scope_order
not_expected = DeveloperOrderedBySalary.first # Jamis -> name DESC
received = DeveloperOrderedBySalary.reordered_by_name.first # David -> name
assert not_expected.id != received.id
end

def test_nested_exclusive_scope def test_nested_exclusive_scope
expected = Developer.find(:all, :limit => 100).collect { |dev| dev.salary } expected = Developer.find(:all, :limit => 100).collect { |dev| dev.salary }
received = DeveloperOrderedBySalary.send(:with_exclusive_scope, :find => { :limit => 100 }) do received = DeveloperOrderedBySalary.send(:with_exclusive_scope, :find => { :limit => 100 }) do
Expand Down
2 changes: 1 addition & 1 deletion activerecord/test/models/developer.rb
Expand Up @@ -88,7 +88,7 @@ class DeveloperOrderedBySalary < ActiveRecord::Base
self.table_name = 'developers' self.table_name = 'developers'
default_scope :order => 'salary DESC' default_scope :order => 'salary DESC'
scope :by_name, order('name DESC') scope :by_name, order('name DESC')
scope :reordered_by_name, reorder('name DESC') scope :reordered_by_name, reorder('name')


def self.all_ordered_by_name def self.all_ordered_by_name
with_scope(:find => { :order => 'name DESC' }) do with_scope(:find => { :order => 'name DESC' }) do
Expand Down

0 comments on commit 16e078d

Please sign in to comment.