Skip to content

Commit

Permalink
Removed deprecated methods partial_updates and family
Browse files Browse the repository at this point in the history
Removed deprecated methods `partial_updates`, `partial_updates?` and
`partial_updates=`
  • Loading branch information
Neeraj Singh committed Jul 1, 2013
1 parent 42cf96f commit 1f45d3c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 25 deletions.
5 changes: 5 additions & 0 deletions activerecord/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
* Removed deprecated methods `partial_updates`, `partial_updates?` and
`partial_updates=`.

*Neeraj Singh*

* Removed deprecated method `scoped`

*Neeraj Singh*
Expand Down
11 changes: 0 additions & 11 deletions activerecord/lib/active_record/attribute_methods/dirty.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,6 @@ module Dirty # :nodoc:

class_attribute :partial_writes, instance_writer: false
self.partial_writes = true

def self.partial_updates=(v); self.partial_writes = v; end
def self.partial_updates?; partial_writes?; end
def self.partial_updates; partial_writes; end

ActiveSupport::Deprecation.deprecate_methods(
singleton_class,
:partial_updates= => :partial_writes=,
:partial_updates? => :partial_writes?,
:partial_updates => :partial_writes
)
end

# Attempts to +save+ the record and clears changed attributes if successful.
Expand Down
14 changes: 0 additions & 14 deletions activerecord/test/cases/dirty_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -608,20 +608,6 @@ def test_datetime_attribute_can_be_updated_with_fractional_seconds
end
end

test "partial_updates config attribute is deprecated" do
klass = Class.new(ActiveRecord::Base)

assert klass.partial_writes?
assert_deprecated { assert klass.partial_updates? }
assert_deprecated { assert klass.partial_updates }

assert_deprecated { klass.partial_updates = false }

assert !klass.partial_writes?
assert_deprecated { assert !klass.partial_updates? }
assert_deprecated { assert !klass.partial_updates }
end

private
def with_partial_writes(klass, on = true)
old = klass.partial_writes?
Expand Down

0 comments on commit 1f45d3c

Please sign in to comment.