Skip to content

Commit

Permalink
Privatize unneededly protected methods in Action View tests
Browse files Browse the repository at this point in the history
  • Loading branch information
amatsuda committed Dec 23, 2016
1 parent 21e5fd4 commit 1f5bed9
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion actionview/test/abstract_unit.rb
Expand Up @@ -163,7 +163,7 @@ def self.build_app(routes = nil)
# Stub Rails dispatcher so it does not get controller references and
# simply return the controller#action as Rack::Body.
class StubDispatcher < ::ActionDispatch::Routing::RouteSet::Dispatcher
protected
private
def controller_reference(controller_param)
controller_param
end
Expand Down
Expand Up @@ -52,7 +52,7 @@ def test_nested_fields_for_with_child_index_option_override_on_a_nested_attribut
assert_dom_equal expected, output_buffer
end

protected
private

def hidden_fields(method = nil)
txt = %{<input name="utf8" type="hidden" value="&#x2713;" />}
Expand Down
2 changes: 1 addition & 1 deletion actionview/test/template/form_helper/form_with_test.rb
Expand Up @@ -2184,7 +2184,7 @@ def test_form_with_only_instantiates_builder_once
assert_equal 1, initialization_count, "form builder instantiated more than once"
end

protected
private
def hidden_fields(options = {})
method = options[:method]

Expand Down
2 changes: 1 addition & 1 deletion actionview/test/template/form_helper_test.rb
Expand Up @@ -3439,7 +3439,7 @@ def test_form_for_only_instantiates_builder_once
assert_equal 1, initialization_count, "form builder instantiated more than once"
end

protected
private

def hidden_fields(options = {})
method = options[:method]
Expand Down
2 changes: 1 addition & 1 deletion actionview/test/template/url_helper_test.rb
Expand Up @@ -810,7 +810,7 @@ def show
render_default
end

protected
private
def render_default
render inline: "<%= link_to_unless_current('tasks', tasks_path) %>\n" +
"<%= link_to_unless_current('tasks', tasks_url) %>"
Expand Down

0 comments on commit 1f5bed9

Please sign in to comment.