for ... in => .each

I believe this is more modern way
rails · May 18, 2011 · 22ed6cb · 22ed6cb
1 parent 9d8e2fb
commit 22ed6cb
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/railties/lib/rails/generators/erb/scaffold/templates/_form.html.erb b/railties/lib/rails/generators/erb/scaffold/templates/_form.html.erb
@@ -11,7 +11,7 @@
     </div>
   <%% end %>
 
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
   <div class="field">
     <%%= f.label :<%= attribute.name %> %><br />
     <%%= f.<%= attribute.field_type %> :<%= attribute.name %> %>

diff --git a/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb b/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb
@@ -2,7 +2,7 @@
 
 <table>
   <tr>
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
     <th><%= attribute.human_name %></th>
 <% end -%>
     <th></th>
@@ -12,7 +12,7 @@
 
 <%% @<%= plural_table_name %>.each do |<%= singular_table_name %>| %>
   <tr>
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
     <td><%%= <%= singular_table_name %>.<%= attribute.name %> %></td>
 <% end -%>
     <td><%%= link_to 'Show', <%= singular_table_name %> %></td>

diff --git a/railties/lib/rails/generators/erb/scaffold/templates/show.html.erb b/railties/lib/rails/generators/erb/scaffold/templates/show.html.erb
@@ -1,6 +1,6 @@
 <p id="notice"><%%= notice %></p>
 
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
 <p>
   <b><%= attribute.human_name %>:</b>
   <%%= @<%= singular_table_name %>.<%= attribute.name %> %>

diff --git a/railties/lib/rails/generators/rails/controller/templates/controller.rb b/railties/lib/rails/generators/rails/controller/templates/controller.rb
@@ -1,6 +1,6 @@
 <% module_namespacing do -%>
 class <%= class_name %>Controller < ApplicationController
-<% for action in actions -%>
+<% actions.each do |action| -%>
   def <%= action %>
   end
 

diff --git a/railties/lib/rails/generators/test_unit/controller/templates/functional_test.rb b/railties/lib/rails/generators/test_unit/controller/templates/functional_test.rb
@@ -7,7 +7,7 @@ class <%= class_name %>ControllerTest < ActionController::TestCase
   #   assert true
   # end
 <% else -%>
-<% for action in actions -%>
+<% actions.each do |action| -%>
   test "should get <%= action %>" do
     get :<%= action %>
     assert_response :success

diff --git a/railties/lib/rails/generators/test_unit/mailer/templates/functional_test.rb b/railties/lib/rails/generators/test_unit/mailer/templates/functional_test.rb
@@ -2,7 +2,7 @@
 
 <% module_namespacing do -%>
 class <%= class_name %>Test < ActionMailer::TestCase
-<% for action in actions -%>
+<% actions.each do |action| -%>
   test "<%= action %>" do
     mail = <%= class_name %>.<%= action %>
     assert_equal <%= action.to_s.humanize.inspect %>, mail.subject

diff --git a/railties/lib/rails/generators/test_unit/model/templates/fixtures.yml b/railties/lib/rails/generators/test_unit/model/templates/fixtures.yml
@@ -2,12 +2,12 @@
 
 <% unless attributes.empty? -%>
 one:
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
   <%= attribute.name %>: <%= attribute.default %>
 <% end -%>
 
 two:
-<% for attribute in attributes -%>
+<% attributes.each do |attribute| -%>
   <%= attribute.name %>: <%= attribute.default %>
 <% end -%>
 <% else -%>
@@ -20,4 +20,4 @@ one: {}
 #
 two: {}
 #  column: value
-<% end -%>
+<% end -%>