Skip to content

Commit

Permalink
Finally! None of our tests are order_dependent!
Browse files Browse the repository at this point in the history
  • Loading branch information
amatsuda committed Aug 14, 2014
1 parent 0127f02 commit 2440933
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions activerecord/test/cases/helper.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -201,8 +201,3 @@ def in_time_zone(zone)
end end


require 'mocha/setup' # FIXME: stop using mocha require 'mocha/setup' # FIXME: stop using mocha

# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.my_tests_are_order_dependent!

7 comments on commit 2440933

@tenderlove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

@zzak
Copy link
Member

@zzak zzak commented on 2440933 Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💣

@guilleiguaran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sgrif
Copy link
Contributor

@sgrif sgrif commented on 2440933 Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@jeremy
Copy link
Member

@jeremy jeremy commented on 2440933 Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:tada:

@ajb
Copy link

@ajb ajb commented on 2440933 Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just lurking on the rails commit log and found this. Congrats, all!

@jonatack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

Please sign in to comment.