Skip to content

Commit

Permalink
Add a couple of missing requires in AR
Browse files Browse the repository at this point in the history
  • Loading branch information
@fxn
fxn committed Mar 20, 2022
1 parent 7d87086 commit 2d80591
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions activerecord/lib/active_record/scoping.rb
View file
@@ -1,6 +1,8 @@
# frozen_string_literal: true

require "active_support/core_ext/module/delegation"
require "active_record/scoping/default"
require "active_record/scoping/named"

module ActiveRecord
module Scoping
Expand Down

2 comments on commit 2d80591

@skipkayhil
Copy link
Member

@skipkayhil skipkayhil commented on 2d80591 Mar 20, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fxn should these modules not be autoloaded?

rails/activerecord/lib/active_record.rb

Lines 144 to 151 in 4103a4a

module Scoping
extend ActiveSupport::Autoload
eager_autoload do
autoload :Default
autoload :Named
end
end

@fxn
Copy link
Member Author

@fxn fxn commented on 2d80591 Mar 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skipkayhil oh, you're right. I am going to revert, thanks!

Please sign in to comment.