Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Make partial counter start from 0.

Signed-off-by: Pratik Naik <>
  • Loading branch information...
commit 2e0765a00361781fb9bff2a7ca8996eab1f01bd4 1 parent df8154c
Frederick Cheung fcheung authored lifo committed
2  actionpack/lib/action_view/partial_template.rb
@@ -22,10 +22,10 @@ def render
def render_member(object)
- @locals[@counter_name] += 1
@locals[:object] = @locals[@variable_name] = object
template = render_template
+ @locals[@counter_name] += 1
4 actionpack/test/controller/new_render_test.rb
@@ -742,7 +742,7 @@ def test_partial_collection
def test_partial_collection_with_counter
get :partial_collection_with_counter
- assert_equal "david1mary2", @response.body
+ assert_equal "david0mary1", @response.body
def test_partial_collection_with_locals
@@ -762,7 +762,7 @@ def test_partial_collection_shorthand_with_locals
def test_partial_collection_shorthand_with_different_types_of_records
get :partial_collection_shorthand_with_different_types_of_records
- assert_equal "Bonjour bad customer: mark1Bonjour good customer: craig2Bonjour bad customer: john3Bonjour good customer: zach4Bonjour good customer: brandon5Bonjour bad customer: dan6", @response.body
+ assert_equal "Bonjour bad customer: mark0Bonjour good customer: craig1Bonjour bad customer: john2Bonjour good customer: zach3Bonjour good customer: brandon4Bonjour bad customer: dan5", @response.body
def test_empty_partial_collection

3 comments on commit 2e0765a

Chris Eppstein

Now we have to go and change our code back to expecting a 1-based index. ::sigh::

Jeremy Kemper

Sigh? It’s fixed, man — rejoice!!

Jason L Perry

Thanks for fixing this, I got flustered when I read that the 1-based index was desired behavior*. From the changes here, it looks as if this was an unintended bug after all?

Please sign in to comment.
Something went wrong with that request. Please try again.