Skip to content

Commit

Permalink
Truncate now has the ability to receive a html option that allows it …
Browse files Browse the repository at this point in the history
…to call rails helpers.

This way if my text is long I don't have to do something like this:

.text
= truncate(@text, :length => 27)

 if @text.size >= 27
    = link_to "continue", notes_path, ....."")
  • Loading branch information
lellisga committed May 26, 2012
1 parent 2114e21 commit 38813da
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 10 deletions.
14 changes: 12 additions & 2 deletions actionpack/lib/action_view/helpers/text_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,18 @@ def safe_concat(string)
#
# truncate("<p>Once upon a time in a world far far away</p>")
# # => "<p>Once upon a time in a wo..."
def truncate(text, options = {})
text.truncate(options.fetch(:length, 30), options) if text
#
# truncate("Once upon a time in a world far far away") { link_to "Continue", "#" }
# # => "Once upon a time in a wo...<a href="#">Continue</a>"
def truncate(text, options = {}, &block)
return unless text

options = { :length => 30 }.merge!(options)
length = options.delete(:length)

content = ERB::Util.html_escape(text.truncate(length, options))
content << capture(&block) if block_given? && text.length > length
content
end

# Highlights one or more +phrases+ everywhere in +text+ by inserting it into
Expand Down
37 changes: 29 additions & 8 deletions actionpack/test/template/text_helper_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,11 @@ def test_simple_format_does_not_modify_the_options_hash
assert_equal options, passed_options
end

def test_truncate_should_not_be_html_safe
assert !truncate("Hello World!", :length => 12).html_safe?
end

def test_truncate
assert_equal "Hello World!", truncate("Hello World!", :length => 12)
assert_equal "Hello Wor...", truncate("Hello World!!", :length => 12)
end

def test_truncate_should_not_escape_input
assert_equal "Hello <sc...", truncate("Hello <script>code!</script>World!!", :length => 12)
end

def test_truncate_should_use_default_length_of_30
str = "This is a string that will go longer then the default truncate length of 30"
assert_equal str[0...27] + "...", truncate(str)
Expand All @@ -114,6 +106,35 @@ def test_truncate_does_not_modify_the_options_hash
assert_equal options, passed_options
end

def test_truncate_with_link_options
assert_equal "Here's a long test and I...<a href=\"#\">Continue</a>",
truncate("Here's a long test and I need a continue to read link", :length => 27) { link_to 'Continue', '#' }
end

def test_truncate_should_not_mutate_the_options_hash
options = { :length => 27 }
truncate("Here's a long test and I need a continue to read link", options) { link_to 'Continue', '#' }
assert_equal({ :length => 27 }, options)
end

def test_truncate_should_be_html_safe
assert truncate("Hello World!", :length => 12).html_safe?
end

def test_truncate_should_escape_the_input
assert_equal "Hello &lt;sc...", truncate("Hello <script>code!</script>World!!", :length => 12)
end

def test_truncate_with_block_should_be_html_safe
truncated = truncate("Here's a long test and I need a continue to read link", :length => 27) { link_to 'Continue', '#' }
assert truncated.html_safe?
end

def test_truncate_with_block_should_escape_the_input
assert_equal "&lt;script&gt;code!&lt;/script&gt;He...<a href=\"#\">Continue</a>",
truncate("<script>code!</script>Here's a long test and I need a continue to read link", :length => 27) { link_to 'Continue', '#' }
end

def test_highlight_should_be_html_safe
assert highlight("This is a beautiful morning", "beautiful").html_safe?
end
Expand Down
4 changes: 4 additions & 0 deletions activesupport/test/core_ext/string_ext_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,10 @@ def test_truncate_multibyte
"\354\225\204\353\246\254\353\236\221 \354\225\204\353\246\254 \354\225\204\353\235\274\353\246\254\354\230\244".force_encoding('UTF-8').truncate(10)
end

def test_truncate_should_not_be_html_safe
assert !"Hello World!".truncate(12).html_safe?
end

def test_constantize
run_constantize_tests_on do |string|
string.constantize
Expand Down

0 comments on commit 38813da

Please sign in to comment.