-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dbedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get a fresh test failure under postgres (9.1) that I suspect is caused by this commit:
vlad@mbp:activerecord> rake postgresql:rebuild_databases
vlad@mbp:activerecord> ARCONN=postgresql ruby -Itest test/cases/migration_test.rb
Using postgresql with Identity Map off
Loaded suite test/cases/migration_test
Started
.....................................................................................................E.............................
Finished in 18.715265 seconds.
test_native_decimal_insert_manual_vs_automatic(MigrationTest):
ActiveRecord::StatementInvalid: PGError: ERROR: column "created_at" is of type timestamp without time zone but expression is of type integer
LINE 1: ..., updated_at) values (12345678901234567890.0123456789, 0, 0)
^
HINT: You will need to rewrite or cast the expression.
: insert into people (wealth, created_at, updated_at) values (12345678901234567890.0123456789, 0, 0)
/web/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:581:in
async_exec' /web/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:581:in
block in execute'/web/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:257:in
block in log' /web/rails/activesupport/lib/active_support/notifications/instrumenter.rb:20:in
instrument'/web/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:252:in
log' /web/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:580:in
execute'test/cases/migration_test.rb:478:in
test_native_decimal_insert_manual_vs_automatic' /Users/vlad/.rvm/gems/ruby-1.9.2-p180/gems/mocha-0.10.0/lib/mocha/integration/mini_test/version_142_to_172.rb:27:in
run'/web/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in
block in run' /web/rails/activesupport/lib/active_support/callbacks.rb:408:in
_run_setup_callbacks'/web/rails/activesupport/lib/active_support/callbacks.rb:81:in
run_callbacks' /web/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in
run'131 tests, 372 assertions, 0 failures, 1 errors, 0 skips
Test run options: --seed 35916
3dbedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a same error with PostgreSQL 9.1 and Oracle. Then opened a pull request #3349.
3dbedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperham What was the reason for this change? This seems like a sane default to me.
3dbedd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperham Sorry - this comment was supposed to go on the REVERT of this commit. 😕