Skip to content

Commit

Permalink
Merge pull request #50724 from aeroastro/feature/fix-minitest-dependency
Browse files Browse the repository at this point in the history
Fix failing test due to the relative path output of minitest at v5.21.0
  • Loading branch information
eileencodes committed Jan 12, 2024
1 parent 1f8c6c3 commit 404e1fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion railties/test/generators/plugin_test_runner_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def test_output_inline_by_default
create_test_file "post", pass: false

output = run_test_command("test/post_test.rb")
expect = %r{Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth \[[^\]]+test/post_test.rb:6\]:\nwups!\n\nbin/test (/private)?#{plugin_path}/test/post_test.rb:4}
expect = %r{Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth \[.*?test/post_test.rb:6\]:\nwups!\n\nbin/test (/private)?#{plugin_path}/test/post_test.rb:4}
assert_match expect, output
end

Expand Down
2 changes: 1 addition & 1 deletion railties/test/generators/test_runner_in_engine_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_rerun_snippet_is_relative_path
create_test_file "post", pass: false

output = run_test_command("test/post_test.rb")
expect = %r{Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth \[[^\]]+test/post_test\.rb:6\]:\nwups!\n\nbin/rails test test/post_test\.rb:4}
expect = %r{Running:\n\nPostTest\nF\n\nFailure:\nPostTest#test_truth \[.*?test/post_test\.rb:6\]:\nwups!\n\nbin/rails test test/post_test\.rb:4}
assert_match expect, output
end

Expand Down

0 comments on commit 404e1fc

Please sign in to comment.