Defer creating Request object until the object is in need in the exce…

…ptional case
rails · Dec 15, 2022 · 41b3e61 · 41b3e61
1 parent 698f126
commit 41b3e61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb b/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb
@@ -24,7 +24,6 @@ def initialize(app, routes_app = nil, response_format = :default, interceptors =
     end
 
     def call(env)
-      request = ActionDispatch::Request.new env
       _, headers, body = response = @app.call(env)
 
       if headers["X-Cascade"] == "pass"
@@ -34,6 +33,7 @@ def call(env)
 
       response
     rescue Exception => exception
+      request = ActionDispatch::Request.new env
       backtrace_cleaner = request.get_header("action_dispatch.backtrace_cleaner")
       wrapper = ExceptionWrapper.new(backtrace_cleaner, exception)
 

diff --git a/actionpack/lib/action_dispatch/middleware/show_exceptions.rb b/actionpack/lib/action_dispatch/middleware/show_exceptions.rb
@@ -22,9 +22,9 @@ def initialize(app, exceptions_app)
     end
 
     def call(env)
-      request = ActionDispatch::Request.new env
       @app.call(env)
     rescue Exception => exception
+      request = ActionDispatch::Request.new env
       if request.show_exceptions?
         render_exception(request, exception)
       else