-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Raise UnknownAttributeError when unknown attributes are suppl…
…ied via mass assignment" This reverts commit 108db00.
- Loading branch information
Showing
2 changed files
with
1 addition
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41efd73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t really know where to put this comment (sorry), but it’s a bit related to this. The test on line 493 of activerecord/test/cases/base_test.rb (test_initialize_with_invalid_attribute) doesn’t fail when I think it should, because as far as I can tell now entering February 31 (invalid date) now saves as March 2 instead of raising a MultiparameterAssignmentErrors. I’m not sure when this changed or not.
Unless I’m mis-reading the test, it seems like it doesn’t fail because the rescue is never called, and so neither are the asserts. It should probably be an assert_raises….
let me know if there’s a better place to put this comment.
41efd73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdb You can try mailing http://groups.google.com/group/rubyonrails-core