Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
store enum mapping using
Strings
instead of Symbols
.
This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem.
- Loading branch information
Showing
2 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44406d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found this commit with the gems-status software (github.com/jordimassaguerpla/gems-status) why is that a security problem? And if so, why has not yet been released and assigned a CVE entry?
44406d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordimassaguerpla normally
to_sym
can be a security problem, in this case it is not. The commit message talk about this possibility, not about a problem.44406d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordimassaguerpla this is a master feature only, so there's nothing possibly wrong with it to worry about. Thanks.
44406d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your comments.