Merge pull request #46910 from skipkayhil/more-string-include

Fix Performance/StringInclude that RuboCop can't
rails · Jan 7, 2023 · 481c169 · 481c169
2 parents 131307e + 583ce94
commit 481c169
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/actionpack/lib/action_dispatch/http/mime_type.rb b/actionpack/lib/action_dispatch/http/mime_type.rb
@@ -293,7 +293,7 @@ def match?(mime_type)
     end
 
     def html?
-      (symbol == :html) || /html/.match?(@string)
+      (symbol == :html) || @string.include?("html")
     end
 
     def all?; false; end

diff --git a/actionpack/lib/action_dispatch/http/permissions_policy.rb b/actionpack/lib/action_dispatch/http/permissions_policy.rb
@@ -55,7 +55,7 @@ def call(env)
       private
         def html_response?(headers)
           if content_type = headers[CONTENT_TYPE]
-            /html/.match?(content_type)
+            content_type.include?("html")
           end
         end