remove intermediate assignments

rails · Aug 1, 2013 · 4b87854 · 4b87854
1 parent 5b527dc
commit 4b87854
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/activerecord/lib/active_record/associations/builder/association.rb b/activerecord/lib/active_record/associations/builder/association.rb
@@ -44,9 +44,8 @@ def initialize(name, scope, options)
 
       validate_options
 
-      if @scope && @scope.arity == 0
-        prev_scope = @scope
-        @scope = proc { instance_exec(&prev_scope) }
+      if scope && scope.arity == 0
+        @scope = proc { instance_exec(&scope) }
       end
     end
 

diff --git a/activerecord/lib/active_record/associations/builder/collection_association.rb b/activerecord/lib/active_record/associations/builder/collection_association.rb
@@ -78,10 +78,8 @@ def #{name.to_s.singularize}_ids=(ids)
     private
 
     def wrap_scope(scope, mod)
-      prev_scope = scope
-
-      if prev_scope
-        proc { |owner| instance_exec(owner, &prev_scope).extending(mod) }
+      if scope
+        proc { |owner| instance_exec(owner, &scope).extending(mod) }
       else
         proc { extending(mod) }
       end