Fix that changing a store should mark the store attribute as changed

rails · Oct 25, 2011 · 5daf077 · 5daf077 · gamov · Oct 25, 2012
1 parent 85b64f9
commit 5daf077
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/activerecord/lib/active_record/store.rb b/activerecord/lib/active_record/store.rb
@@ -37,6 +37,7 @@ def store_accessor(store_attribute, *keys)
         Array(keys).flatten.each do |key|
           define_method("#{key}=") do |value|
             send(store_attribute)[key] = value
+            send("#{store_attribute}_will_change!")
           end
 
           define_method(key) do

diff --git a/activerecord/test/cases/store_test.rb b/activerecord/test/cases/store_test.rb
@@ -26,4 +26,9 @@ class StoreTest < ActiveRecord::TestCase
 
     assert 'graeters', @john.reload.settings[:icecream]
   end
+
+  test "updating the store will mark it as changed" do
+    @john.color = 'red'
+    assert @john.settings_changed?
+  end
 end