Skip to content

Commit

Permalink
Fix #8414. Performance problem with postgresql adapter primary_key fu…
Browse files Browse the repository at this point in the history
…nction.
  • Loading branch information
kennyj committed Dec 4, 2012
1 parent d3f4625 commit 634d28e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions activerecord/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Rails 4.0.0 (unreleased) ##

* Fix performance problem with primary_key method in PostgreSQL adapter when having many schemas.
Uses pg_constraint table instead of pg_depend table which has many records in general.
Fix #8414

*kennyj*

* Do not instantiate intermediate Active Record objects when eager loading.
These records caused `after_find` to run more than expected.
Fix #3313
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,11 @@ def pk_and_sequence_for(table) #:nodoc:
# Returns just a table's primary key
def primary_key(table)
row = exec_query(<<-end_sql, 'SCHEMA').rows.first
SELECT DISTINCT(attr.attname)
SELECT attr.attname
FROM pg_attribute attr
INNER JOIN pg_depend dep ON attr.attrelid = dep.refobjid AND attr.attnum = dep.refobjsubid
INNER JOIN pg_constraint cons ON attr.attrelid = cons.conrelid AND attr.attnum = cons.conkey[1]
WHERE cons.contype = 'p'
AND dep.refobjid = '#{quote_table_name(table)}'::regclass
AND cons.conrelid = '#{quote_table_name(table)}'::regclass
end_sql

row && row.first
Expand Down

0 comments on commit 634d28e

Please sign in to comment.