Skip to content

Commit

Permalink
End-of-line whitespace hunt
Browse files Browse the repository at this point in the history
  • Loading branch information
sunny committed May 28, 2013
1 parent ff684ea commit 666d028
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 27 deletions.
4 changes: 2 additions & 2 deletions guides/source/active_record_validations.md
Expand Up @@ -677,13 +677,13 @@ class GoodnessValidator
def initialize(person)
@person = person
end

def validate
if some_complex_condition_involving_ivars_and_private_methods?
@person.errors[:base] << "This person is evil"
end
end

#
end
```
Expand Down
4 changes: 2 additions & 2 deletions guides/source/api_documentation_guidelines.md
Expand Up @@ -25,7 +25,7 @@ Write in present tense: "Returns a hash that...", rather than "Returned a hash t
Start comments in upper case. Follow regular punctuation rules:

```ruby
# Declares an attribute reader backed by an internally-named
# Declares an attribute reader backed by an internally-named
# instance variable.
def attr_internal_reader(*attrs)
...
Expand Down Expand Up @@ -57,7 +57,7 @@ Use two spaces to indent chunks of code--that is, for markup purposes, two space
Short docs do not need an explicit "Examples" label to introduce snippets; they just follow paragraphs:

```ruby
# Converts a collection of elements into a formatted string by
# Converts a collection of elements into a formatted string by
# calling +to_s+ on all elements and joining them.
#
# Blog.all.to_formatted_s # => "First PostSecond PostThird Post"
Expand Down
24 changes: 12 additions & 12 deletions guides/source/association_basics.md
Expand Up @@ -1692,7 +1692,7 @@ person.posts.inspect # => [#<Post id: 5, name: "a1">, #<Post id: 5, name: "a1">]
Reading.all.inspect # => [#<Reading id: 12, person_id: 5, post_id: 5>, #<Reading id: 13, person_id: 5, post_id: 5>]
```

In the above case there are two readings and `person.posts` brings out both of
In the above case there are two readings and `person.posts` brings out both of
them even though these records are pointing to the same post.

Now let's set `distinct`:
Expand All @@ -1711,24 +1711,24 @@ person.posts.inspect # => [#<Post id: 7, name: "a1">]
Reading.all.inspect # => [#<Reading id: 16, person_id: 7, post_id: 7>, #<Reading id: 17, person_id: 7, post_id: 7>]
```

In the above case there are still two readings. However `person.posts` shows
In the above case there are still two readings. However `person.posts` shows
only one post because the collection loads only unique records.

If you want to make sure that, upon insertion, all of the records in the
persisted association are distinct (so that you can be sure that when you
inspect the association that you will never find duplicate records), you should
add a unique index on the table itself. For example, if you have a table named
``person_posts`` and you want to make sure all the posts are unique, you could
If you want to make sure that, upon insertion, all of the records in the
persisted association are distinct (so that you can be sure that when you
inspect the association that you will never find duplicate records), you should
add a unique index on the table itself. For example, if you have a table named
``person_posts`` and you want to make sure all the posts are unique, you could
add the following in a migration:

```ruby
add_index :person_posts, :post, :unique => true
```

Note that checking for uniqueness using something like ``include?`` is subject
to race conditions. Do not attempt to use ``include?`` to enforce distinctness
in an association. For instance, using the post example from above, the
following code would be racy because multiple users could be attempting this
Note that checking for uniqueness using something like ``include?`` is subject
to race conditions. Do not attempt to use ``include?`` to enforce distinctness
in an association. For instance, using the post example from above, the
following code would be racy because multiple users could be attempting this
at the same time:

```ruby
Expand Down Expand Up @@ -1942,7 +1942,7 @@ TIP: The `:foreign_key` and `:association_foreign_key` options are useful when s

```ruby
class User < ActiveRecord::Base
has_and_belongs_to_many :friends,
has_and_belongs_to_many :friends,
class_name: "User",
foreign_key: "this_user_id",
association_foreign_key: "other_user_id"
Expand Down
16 changes: 8 additions & 8 deletions guides/source/getting_started.md
Expand Up @@ -264,7 +264,7 @@ Blog::Application.routes.draw do
end
```

If you run `rake routes`, you'll see that all the routes for the
If you run `rake routes`, you'll see that all the routes for the
standard RESTful actions.

```bash
Expand Down Expand Up @@ -534,7 +534,7 @@ def create
@post = Post.new(params[:post])

@post.save
redirect_to @post
redirect_to @post
end
```

Expand All @@ -553,14 +553,14 @@ whether the model was saved or not.

If you submit the form again now, Rails will complain about not finding
the `show` action. That's not very useful though, so let's add the
`show` action before proceeding.
`show` action before proceeding.

```ruby
post GET /posts/:id(.:format) posts#show
```

The special syntax `:id` tells rails that this route expects an `:id`
parameter, which in our case will be the id of the post.
parameter, which in our case will be the id of the post.

As we did before, we need to add the `show` action in
`app/controllers/posts_controller.rb` and its respective view.
Expand Down Expand Up @@ -621,7 +621,7 @@ Visit <http://localhost:3000/posts/new> and give it a try!

### Listing all posts

We still need a way to list all our posts, so let's do that.
We still need a way to list all our posts, so let's do that.
We'll use a specific route from `config/routes.rb`:

```ruby
Expand Down Expand Up @@ -763,7 +763,7 @@ def create
@post = Post.new(params[:post].permit(:title, :text))

if @post.save
redirect_to @post
redirect_to @post
else
render 'new'
end
Expand Down Expand Up @@ -1084,7 +1084,7 @@ together.
</table>
```

Here we're using `link_to` in a different way. We pass the named route as the first argument,
Here we're using `link_to` in a different way. We pass the named route as the first argument,
and then the final two keys as another argument. The `:method` and `:'data-confirm'`
options are used as HTML5 attributes so that when the link is clicked,
Rails will first show a confirm dialog to the user, and then submit the link with method `delete`.
Expand All @@ -1095,7 +1095,7 @@ generated the application. Without this file, the confirmation dialog box wouldn
![Confirm Dialog](images/getting_started/confirm_dialog.png)

Congratulations, you can now create, show, list, update and destroy
posts.
posts.

TIP: In general, Rails encourages the use of resources objects in place
of declaring routes manually.
Expand Down
2 changes: 1 addition & 1 deletion guides/source/ruby_on_rails_guides_guidelines.md
Expand Up @@ -63,7 +63,7 @@ Those guidelines apply also to guides.
HTML Guides
-----------

Before generating the guides, make sure that you have the latest version of Bundler installed on your system. As of this writing, you must install Bundler 1.3.5 on your device.
Before generating the guides, make sure that you have the latest version of Bundler installed on your system. As of this writing, you must install Bundler 1.3.5 on your device.

To install the latest version of Bundler, simply run the `gem install bundler` command

Expand Down
2 changes: 1 addition & 1 deletion guides/source/testing.md
Expand Up @@ -159,7 +159,7 @@ class PostTest < ActiveSupport::TestCase

The `PostTest` class defines a _test case_ because it inherits from `ActiveSupport::TestCase`. `PostTest` thus has all the methods available from `ActiveSupport::TestCase`. You'll see those methods a little later in this guide.

Any method defined within a class inherited from `MiniTest::Unit::TestCase`
Any method defined within a class inherited from `MiniTest::Unit::TestCase`
(which is the superclass of `ActiveSupport::TestCase`) that begins with `test` (case sensitive) is simply called a test. So, `test_password`, `test_valid_password` and `testValidPassword` all are legal test names and are run automatically when the test case is run.

Rails adds a `test` method that takes a test name and a block. It generates a normal `MiniTest::Unit` test with method names prefixed with `test_`. So,
Expand Down
2 changes: 1 addition & 1 deletion guides/source/working_with_javascript_in_rails.md
Expand Up @@ -394,4 +394,4 @@ Here are some helpful links to help you learn even more:
* [jquery-ujs list of external articles](https://github.com/rails/jquery-ujs/wiki/External-articles)
* [Rails 3 Remote Links and Forms: A Definitive Guide](http://www.alfajango.com/blog/rails-3-remote-links-and-forms/)
* [Railscasts: Unobtrusive JavaScript](http://railscasts.com/episodes/205-unobtrusive-javascript)
* [Railscasts: Turbolinks](http://railscasts.com/episodes/390-turbolinks)
* [Railscasts: Turbolinks](http://railscasts.com/episodes/390-turbolinks)

0 comments on commit 666d028

Please sign in to comment.