add bigserial pk support

rails · Oct 30, 2014 · 6dc1787 · 6dc1787
1 parent f9d4b50
commit 6dc1787
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb b/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
@@ -78,6 +78,7 @@ class PostgreSQLAdapter < AbstractAdapter
 
       NATIVE_DATABASE_TYPES = {
         primary_key: "serial primary key",
+        bigserial: "bigserial",
         string:      { name: "character varying" },
         text:        { name: "text" },
         integer:     { name: "integer" },

diff --git a/activerecord/lib/active_record/schema_dumper.rb b/activerecord/lib/active_record/schema_dumper.rb
@@ -118,6 +118,8 @@ def table(table, stream)
           if pkcol
             if pk != 'id'
               tbl.print %Q(, primary_key: "#{pk}")
+            elsif pkcol.sql_type == 'bigint'
+              tbl.print ", id: :bigserial"
             elsif pkcol.sql_type == 'uuid'
               tbl.print ", id: :uuid"
               tbl.print %Q(, default: "#{pkcol.default_function}") if pkcol.default_function

diff --git a/activerecord/test/cases/adapters/postgresql/uuid_test.rb b/activerecord/test/cases/adapters/postgresql/uuid_test.rb
@@ -110,6 +110,26 @@ def test_uuid_formats
   end
 end
 
+class PostgresqlLargeKeysTest < ActiveRecord::TestCase
+  include PostgresqlUUIDHelper
+  def setup
+    connection.create_table('big_serials', id: :bigserial) do |t|
+      t.string 'name'
+    end
+  end
+
+  def test_omg
+    schema = StringIO.new
+    ActiveRecord::SchemaDumper.dump(connection, schema)
+    assert_match "create_table \"big_serials\", id: :bigserial, force: true",
+      schema.string
+  end
+
+  def teardown
+    drop_table "big_serials"
+  end
+end
+
 class PostgresqlUUIDGenerationTest < ActiveRecord::TestCase
   include PostgresqlUUIDHelper