Skip to content

Commit

Permalink
Merge pull request #30377 from keepcosmos/delegate-missing-methods
Browse files Browse the repository at this point in the history
Delegate :rindex, :slice, :rotate(missing) to 'records'
  • Loading branch information
matthewd committed Aug 31, 2017
2 parents d81a2ed + 3980572 commit 7721f23
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions activerecord/lib/active_record/relation/delegation.rb
Expand Up @@ -39,9 +39,9 @@ def inherited(child_class)
# for each different klass, and the delegations are compiled into that subclass only.

delegate :to_xml, :encode_with, :length, :each, :uniq, :to_ary, :join,
:[], :&, :|, :+, :-, :sample, :reverse, :compact, :in_groups, :in_groups_of,
:[], :&, :|, :+, :-, :sample, :reverse, :rotate, :compact, :in_groups, :in_groups_of,
:to_sentence, :to_formatted_s, :as_json,
:shuffle, :split, :index, to: :records
:shuffle, :split, :slice, :index, :rindex, to: :records

delegate :table_name, :quoted_table_name, :primary_key, :quoted_primary_key,
:connection, :columns_hash, to: :klass
Expand Down
4 changes: 2 additions & 2 deletions activerecord/test/cases/relation/delegation_test.rb
Expand Up @@ -10,8 +10,8 @@ module DelegationWhitelistTests
:+, :-, :|, :&, :[], :shuffle,
:all?, :collect, :compact, :detect, :each, :each_cons, :each_with_index,
:exclude?, :find_all, :flat_map, :group_by, :include?, :length,
:map, :none?, :one?, :partition, :reject, :reverse,
:sample, :second, :sort, :sort_by, :third,
:map, :none?, :one?, :partition, :reject, :reverse, :rotate,
:sample, :second, :sort, :sort_by, :slice, :third, :index, :rindex,
:to_ary, :to_set, :to_xml, :to_yaml, :join,
:in_groups, :in_groups_of, :to_sentence, :to_formatted_s, :as_json
]
Expand Down

0 comments on commit 7721f23

Please sign in to comment.