'string'[0, index] is faster and more eco-friendly than 'string'.spli…

…t.first
rails · Dec 17, 2022 · 78599ba · 78599ba
1 parent 40b1c60
commit 78599ba
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/actionpack/lib/action_dispatch/http/mime_type.rb b/actionpack/lib/action_dispatch/http/mime_type.rb
@@ -171,7 +171,9 @@ def register(string, symbol, mime_type_synonyms = [], extension_synonyms = [], s
 
       def parse(accept_header)
         if !accept_header.include?(",")
-          accept_header = accept_header.split(PARAMETER_SEPARATOR_REGEXP).first
+          if (index = accept_header.index(PARAMETER_SEPARATOR_REGEXP))
+            accept_header = accept_header[0, index]
+          end
           return [] unless accept_header
           parse_trailing_star(accept_header) || [Mime::Type.lookup(accept_header)].compact
         else