renames the :abort deprecation behaviour to :raise

That is a better name, thanks @jeremy.
rails · Aug 12, 2013 · 8a099f1 · 8a099f1
1 parent 8381a49
commit 8a099f1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
@@ -1,9 +1,9 @@
 ## unreleased ##
 
-*   Adds a new deprecation behaviour that aborts the application. Throwing this
+*   Adds a new deprecation behaviour that raises an exception. Throwing this
     line into +config/environments/development.rb+
 
-        ActiveSupport::Deprecation.behavior = :abort
+        ActiveSupport::Deprecation.behavior = :raise
 
     will cause the application to raise an +ActiveSupport::DeprecationException+
     on deprecations.

diff --git a/activesupport/lib/active_support/deprecation/behaviors.rb b/activesupport/lib/active_support/deprecation/behaviors.rb
@@ -7,7 +7,7 @@ class DeprecationException < StandardError
   class Deprecation
     # Default warning behaviors per Rails.env.
     DEFAULT_BEHAVIORS = {
-      abort: ->(message, callstack) {
+      raise: ->(message, callstack) {
         e = DeprecationException.new(message)
         e.set_backtrace(callstack)
         raise e
@@ -52,7 +52,7 @@ def behavior
       #
       # Available behaviors:
       #
-      # [+abort+]   Raises <tt>ActiveSupport::DeprecationException</tt>.
+      # [+raise+]   Raise <tt>ActiveSupport::DeprecationException</tt>.
       # [+stderr+]  Log all deprecation warnings to +$stderr+.
       # [+log+]     Log all deprecation warnings to +Rails.logger+.
       # [+notify+]  Use +ActiveSupport::Notifications+ to notify +deprecation.rails+.

diff --git a/activesupport/test/deprecation_test.rb b/activesupport/test/deprecation_test.rb
@@ -98,8 +98,8 @@ def test_several_behaviors
     assert_match(/foo=nil/, @b)
   end
 
-  def test_abort_behaviour
-    ActiveSupport::Deprecation.behavior = :abort
+  def test_raise_behaviour
+    ActiveSupport::Deprecation.behavior = :raise
 
     message   = 'Revise this deprecated stuff now!'
     callstack = %w(foo bar baz)
@@ -110,7 +110,7 @@ def test_abort_behaviour
       assert_equal message, e.message
       assert_equal callstack, e.backtrace
     else
-      flunk 'the :abort deprecation behaviour should raise the expected exception'
+      flunk 'the :raise deprecation behaviour should raise the expected exception'
     end
   end