Permalink
Browse files

Array#to_query preserves its ordering. References #7756.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 3edc98a commit 8a7275e7f4addaf7e7f42e32abc23121be87631b @jeremy jeremy committed Mar 11, 2007
View
@@ -1,5 +1,7 @@
*SVN*
+* Array#to_query preserves its ordering. #7756 [Greg Spurrier]
+
* Out-of-range Time calculations transparently overflow to DateTime. Introduce Time#to_datetime. #7706, #7715 [Geoff Buesing]
* DateTime calculations analogous to the Date and Time extensions. #7693 [Geoff Buesing]
@@ -15,7 +15,7 @@ def to_query(key) #:nodoc:
class Array
def to_query(key) #:nodoc:
- collect { |value| value.to_query("#{key}[]") }.sort * '&'
+ collect { |value| value.to_query("#{key}[]") } * '&'
end
end
@@ -544,7 +544,7 @@ def empty.to_param; nil end
end
def test_nested_conversion
- assert_query_equal 'person%5Bname%5D=Nicholas&person%5Blogin%5D=seckar',
+ assert_query_equal 'person%5Blogin%5D=seckar&person%5Bname%5D=Nicholas',
:person => {:name => 'Nicholas', :login => 'seckar'}
end
@@ -558,8 +558,13 @@ def test_array_values
:person => {:id => [10, 20]}
end
+ def test_array_values_are_not_sorted
+ assert_query_equal 'person%5Bid%5D%5B%5D=20&person%5Bid%5D%5B%5D=10',
+ :person => {:id => [20, 10]}
+ end
+
private
def assert_query_equal(expected, actual, message = nil)
- assert_equal expected.split('&').sort, actual.to_query.split('&').sort
+ assert_equal expected.split('&'), actual.to_query.split('&')
end
end

0 comments on commit 8a7275e

Please sign in to comment.