Merge pull request #49299 from BuonOmo/loosen-arel-test

Loosen test condition `Arel::Nodes::Node` descendants
rails · Sep 16, 2023 · 8bd463c · 8bd463c
2 parents 4960de3 + e890ae6
commit 8bd463c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/activerecord/test/cases/arel/nodes_test.rb b/activerecord/test/cases/arel/nodes_test.rb
@@ -16,11 +16,12 @@ def test_every_arel_nodes_have_hash_eql_eqeq_from_same_class
         node_descendants.delete(Arel::Nodes::NodeExpression)
 
         bad_node_descendants = node_descendants.reject do |subnode|
-          eqeq_owner = subnode.instance_method(:==).owner
+          eqeq_method = subnode.instance_method(:==)
+          eqeq_owner = eqeq_method.owner
           eql_owner = subnode.instance_method(:eql?).owner
           hash_owner = subnode.instance_method(:hash).owner
 
-          eqeq_owner < Arel::Nodes::Node &&
+          eqeq_method.super_method && # Not using the ruby default #== method
               eqeq_owner == eql_owner &&
               eqeq_owner == hash_owner
         end