Skip to content

Commit

Permalink
Don't attach UJS form submission handlers to Turbo forms (#42476)
Browse files Browse the repository at this point in the history
* Don't attach UJS form submission handlers to Turbo forms

Allows for easier migration of apps written for UJS, such that new work can be done with Turbo forms that are marked with data-turbo=true.

* Fix duplicate selectors

* Proper fix take 2
  • Loading branch information
dhh committed Jun 15, 2021
1 parent 4e1fee1 commit 8de181d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions actionview/app/assets/javascripts/rails-ujs.coffee
Expand Up @@ -18,10 +18,10 @@
inputChangeSelector: 'select[data-remote], input[data-remote], textarea[data-remote]'

# Form elements bound by rails-ujs
formSubmitSelector: 'form'
formSubmitSelector: 'form:not([data-turbo=true])',

# Form input elements bound by rails-ujs
formInputClickSelector: 'form input[type=submit], form input[type=image], form button[type=submit], form button:not([type]), input[type=submit][form], input[type=image][form], button[type=submit][form], button[form]:not([type])'
formInputClickSelector: 'form:not([data-turbo=true]) input[type=submit], form:not([data-turbo=true]) input[type=image], form:not([data-turbo=true]) button[type=submit], form:not([data-turbo=true]) button:not([type]), input[type=submit][form], input[type=image][form], button[type=submit][form], button[form]:not([type])',

# Form input elements disabled during form submission
formDisableSelector: 'input[data-disable-with]:enabled, button[data-disable-with]:enabled, textarea[data-disable-with]:enabled, input[data-disable]:enabled, button[data-disable]:enabled, textarea[data-disable]:enabled'
Expand Down

0 comments on commit 8de181d

Please sign in to comment.