Skip to content

Commit

Permalink
Shut down the worker pool - don't kill it
Browse files Browse the repository at this point in the history
Different parts of concurrent-ruby's documentation make inconsistent
claims about how kill will behave. It doesn't do the thing we want.
  • Loading branch information
matthewd committed Oct 2, 2016
1 parent e2c1b70 commit 8e17e4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion actioncable/lib/action_cable/server/worker.rb
Expand Up @@ -25,7 +25,7 @@ def initialize(max_size: 5)
# Stop processing work: any work that has not already started
# running will be discarded from the queue
def halt
@executor.kill
@executor.shutdown
end

def stopping?
Expand Down

0 comments on commit 8e17e4a

Please sign in to comment.