Skip to content

Commit

Permalink
Replace the flush parameter with a Hash.
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasmazza committed Jul 24, 2012
1 parent 66b859b commit 9a020bd
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions actionpack/lib/action_view/helpers/capture_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def capture(*args)
#
# <%# Add some other content, or use a different template: %>
#
# <% content_for :navigation, true do %>
# <% content_for :navigation, flush: true do %>
# <li><%= link_to 'Login', :action => 'login' %></li>
# <% end %>
#
Expand All @@ -148,14 +148,14 @@ def capture(*args)
#
# WARNING: content_for is ignored in caches. So you shouldn't use it
# for elements that will be fragment cached.
def content_for(name, content = nil, flush = false, &block)
def content_for(name, content = nil, options = {}, &block)
if content || block_given?
if block_given?
flush = content if content
options = content if content
content = capture(&block)
end
if content
flush ? @view_flow.set(name, content) : @view_flow.append(name, content)
options[:flush] ? @view_flow.set(name, content) : @view_flow.append(name, content)
end
nil
else
Expand Down
18 changes: 9 additions & 9 deletions actionpack/test/template/capture_helper_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def test_content_for_with_multiple_calls
def test_content_for_with_multiple_calls_and_flush
assert ! content_for?(:title)
content_for :title, 'foo'
content_for :title, 'bar', true
content_for :title, 'bar', flush: true
assert_equal 'bar', content_for(:title)
end

Expand All @@ -75,7 +75,7 @@ def test_content_for_with_block_and_multiple_calls_with_flush
content_for :title do
'foo'
end
content_for :title, true do
content_for :title, flush: true do
'bar'
end
assert_equal 'bar', content_for(:title)
Expand All @@ -86,7 +86,7 @@ def test_content_for_with_block_and_multiple_calls_with_flush_nil_content
content_for :title do
'foo'
end
content_for :title, nil, true do
content_for :title, nil, flush: true do
'bar'
end
assert_equal 'bar', content_for(:title)
Expand All @@ -97,7 +97,7 @@ def test_content_for_with_block_and_multiple_calls_without_flush
content_for :title do
'foo'
end
content_for :title, false do
content_for :title, flush: false do
'bar'
end
assert_equal 'foobar', content_for(:title)
Expand All @@ -117,11 +117,11 @@ def test_content_for_with_whitespace_block
def test_content_for_with_whitespace_block_and_flush
assert ! content_for?(:title)
content_for :title, 'foo'
content_for :title, true do
content_for :title, flush: true do
output_buffer << " \n "
nil
end
content_for :title, 'bar', true
content_for :title, 'bar', flush: true
assert_equal 'bar', content_for(:title)
end

Expand All @@ -131,9 +131,9 @@ def test_content_for_returns_nil_when_writing
assert_equal nil, content_for(:title) { output_buffer << 'bar'; nil }
assert_equal nil, content_for(:title) { output_buffer << " \n "; nil }
assert_equal 'foobar', content_for(:title)
assert_equal nil, content_for(:title, 'foo', true)
assert_equal nil, content_for(:title, true) { output_buffer << 'bar'; nil }
assert_equal nil, content_for(:title, true) { output_buffer << " \n "; nil }
assert_equal nil, content_for(:title, 'foo', flush: true)
assert_equal nil, content_for(:title, flush: true) { output_buffer << 'bar'; nil }
assert_equal nil, content_for(:title, flush: true) { output_buffer << " \n "; nil }
assert_equal 'bar', content_for(:title)
end

Expand Down

0 comments on commit 9a020bd

Please sign in to comment.