Why do we add a top-level constant here?

rails · Apr 25, 2015 · 9b3fa76 · 9b3fa76
1 parent 9b36cf0
commit 9b3fa76
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb
@@ -8,8 +8,6 @@ def index() head :ok end
   alias_method :show, :index
 end
 
-ROUTING = ActionDispatch::Routing
-
 # See RFC 3986, section 3.3 for allowed path characters.
 class UriReservedCharactersRoutingTest < ActiveSupport::TestCase
   include RoutingTestHelpers
@@ -871,7 +869,7 @@ def request
 
   def default_route_set
     @default_route_set ||= begin
-      set = ROUTING::RouteSet.new
+      set = ActionDispatch::Routing::RouteSet.new
       set.draw do
         get '/:controller(/:action(/:id))'
       end
@@ -1748,13 +1746,13 @@ def test_generate_with_default_params
 
   include ActionDispatch::RoutingVerbs
 
-  class TestSet < ROUTING::RouteSet
+  class TestSet < ActionDispatch::Routing::RouteSet
     def initialize(block)
       @block = block
       super()
     end
 
-    class Dispatcher < ROUTING::RouteSet::Dispatcher
+    class Dispatcher < ActionDispatch::Routing::RouteSet::Dispatcher
       def initialize(defaults, set, block)
         super(defaults)
         @block = block

diff --git a/railties/test/path_generation_test.rb b/railties/test/path_generation_test.rb
@@ -4,18 +4,16 @@
 require 'rails'
 require 'rails/application'
 
-ROUTING = ActionDispatch::Routing
-
 class PathGenerationTest < ActiveSupport::TestCase
   attr_reader :app
 
-  class TestSet < ROUTING::RouteSet
+  class TestSet < ActionDispatch::Routing::RouteSet
     def initialize(block)
       @block = block
       super()
     end
 
-    class Dispatcher < ROUTING::RouteSet::Dispatcher
+    class Dispatcher < ActionDispatch::Routing::RouteSet::Dispatcher
       def initialize(defaults, set, block)
         super(defaults)
         @block = block