Don't return bare string as rack body

rails · Apr 27, 2009 · a88ddf8 · a88ddf8
1 parent e44cd41
commit a88ddf8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/actionpack/lib/action_dispatch/middleware/failsafe.rb b/actionpack/lib/action_dispatch/middleware/failsafe.rb
@@ -29,9 +29,9 @@ def failsafe_response(exception)
       def failsafe_response_body
         error_path = "#{self.class.error_file_path}/500.html"
         if File.exist?(error_path)
-          File.read(error_path)
+          [File.read(error_path)]
         else
-          "<html><body><h1>500 Internal Server Error</h1></body></html>"
+          ["<html><body><h1>500 Internal Server Error</h1></body></html>"]
         end
       end
 

diff --git a/actionpack/test/controller/dispatcher_test.rb b/actionpack/test/controller/dispatcher_test.rb
@@ -53,7 +53,7 @@ def test_failsafe_response
       assert_equal [
         500,
         {"Content-Type" => "text/html"},
-        "<html><body><h1>500 Internal Server Error</h1></body></html>"
+        ["<html><body><h1>500 Internal Server Error</h1></body></html>"]
       ], dispatch
     end
   end