Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add .rb template handler

This handler simply allows arbitrary Ruby code as a template
  • Loading branch information...
commit ab7ae689e9727781ef39b01a836a746ac75352fc 1 parent 5d264f2
@guilleiguaran guilleiguaran authored
View
2  actionpack/CHANGELOG.md
@@ -1,5 +1,7 @@
## Rails 4.0.0 (unreleased) ##
+* Add .rb template handler, this handler simply allows arbitrary Ruby code as a template. *Guillermo Iguaran*
+
* Add `separator` option for `ActionView::Helpers::TextHelper#excerpt`:
excerpt('This is a very beautiful morning', 'very', :separator => ' ', :radius => 1)
View
1  actionpack/lib/action_view/template/handlers.rb
@@ -10,6 +10,7 @@ def self.extended(base)
base.register_default_template_handler :erb, ERB.new
base.register_template_handler :builder, Builder.new
base.register_template_handler :raw, Raw.new
+ base.register_template_handler :rb, :source.to_proc
@fxn Owner
fxn added a note

:source.to_proc :metal:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
end
@@template_handlers = {}
View
3  actionpack/test/fixtures/ruby_template.rb
@@ -0,0 +1,3 @@
+body = ""
+body << ["Hello", "from", "Ruby", "code"].join(" ")
+body
View
8 actionpack/test/template/render_test.rb
@@ -97,6 +97,14 @@ def test_render_raw_template_with_quotes
assert_equal %q;Here are some characters: !@#$%^&*()-="'}{`; + "\n", @view.render(:template => "plain_text_with_characters")
end
+ def test_render_rb_template_with_handlers
+ assert_equal "Hello from Ruby code", @view.render(:template => "ruby_template")
+ end
+
+ def test_render_rb_template_inline
+ assert_equal '4', @view.render(:inline => "(2**2).to_s", :type => :rb)
+ end
+
def test_render_file_with_localization_on_context_level
old_locale, @view.locale = @view.locale, :da
assert_equal "Hey verden", @view.render(:file => "test/hello_world")

5 comments on commit ab7ae68

@josh
Collaborator

This is pretty annoying change.

If you have any .rb files under a view path, AP is going to try to precompile them.

Just put a module under app/views echo "module Foo; end" > app/views/foo.rb and your app will just crash will an error message saying "module definition in method body".

My personal usage is mustache view classes.

@guilleiguaran

@josh I added this since @dhh asked for it after of see it in Railscasts, I will talk with him on CF to check if we can found any solution or if we should revert this

@josh
Collaborator

I like that jbuilder (and similar extensions) use its own extension, not .rb.

@dhh
Owner

We'll just go with .ruby for now, then.

@guilleiguaran

Done in de1060f

Please sign in to comment.
Something went wrong with that request. Please try again.