Merge pull request #47459 from Shopify/dockerfile-no-version-manager

Don't use a full blown version manager to install nodejs
rails · Feb 22, 2023 · b3770a0 · b3770a0
2 parents 5594c6c + 5606a7f
commit b3770a0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/railties/lib/rails/generators/rails/app/templates/Dockerfile.tt b/railties/lib/rails/generators/rails/app/templates/Dockerfile.tt
@@ -23,9 +23,11 @@ RUN apt-get update -qq && \
 # Install JavaScript dependencies
 ARG NODE_VERSION=<%= dockerfile_node_version %>
 ARG YARN_VERSION=<%= dockerfile_yarn_version %>
-ENV VOLTA_HOME="/usr/local"
-RUN curl https://get.volta.sh | bash && \
-    volta install node@$NODE_VERSION yarn@$YARN_VERSION
+
+RUN git clone https://github.com/nodenv/node-build.git /tmp/node-build/ && \
+    /tmp/node-build/bin/node-build "${NODE_VERSION}" /usr/local && \
+    npm install -g yarn@$YARN_VERSION && \
+    rm -rf /tmp/node-build
 
 <% end -%>
 # Install application gems