-
Notifications
You must be signed in to change notification settings - Fork 21.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Teach ActiveJob to set configs on itself
Previously configs of the form `config.active_job.X` were only forwarded to `ActiveJob::Base`. This teaches Active Job to set them on `ActiveJob` directly instead, if the setter exists. For consistency, this more or less mirrors the way that Active Record does it. Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com> Co-authored-by: Sam Bostock <sam.bostock@shopify.com> --- Fix use_big_decimal_serializer Rails 7.1 default This config should be enabled for new Rails 7.1 apps, or apps that have updated their config to `load_defaults 7.1`, not disabled. This also clarifies the config accessor comment. --- Add contributor documentation comment to load_defaults The process for introducing a change in behavior in Rails can be confusing to new contributors, so a comment is added roughly explaining how to do so, and what belongs in `load_defaults` and `new_framework_defaults`. This comment is aimed at contributors, not consumers, so it is added within the method, rather than above it.
- Loading branch information
1 parent
2b3245d
commit b4fffc3
Showing
4 changed files
with
68 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters