Skip to content

Commit

Permalink
update contribution doc grammar. [ci skip]
Browse files Browse the repository at this point in the history
- Manually applied from #13951.
- Discussion at #13947.
- Removed trailing whitespace from https://github.com/dpmehta02/rails/commit/18044e86af93672dfc38befbe974261e87b3518d

/cc @dpmehta02
  • Loading branch information
kelaraj authored and senny committed Feb 6, 2014
1 parent c82dbc6 commit b9ead0f
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions guides/source/contributing_to_ruby_on_rails.md
Expand Up @@ -201,7 +201,8 @@ If your comment simply says "+1", then odds are that other reviewers aren't goin
Contributing to the Rails Documentation Contributing to the Rails Documentation
--------------------------------------- ---------------------------------------


Ruby on Rails has two main sets of documentation: the guides help you in learning about Ruby on Rails, and the API is a reference. Ruby on Rails has two main sets of documentation: the guides, which help you
learn about Ruby on Rails, and the API, which serves as a reference.


You can help improve the Rails guides by making them more coherent, consistent or readable, adding missing information, correcting factual errors, fixing typos, or bringing it up to date with the latest edge Rails. To get involved in the translation of Rails guides, please see [Translating Rails Guides](https://wiki.github.com/rails/docrails/translating-rails-guides). You can help improve the Rails guides by making them more coherent, consistent or readable, adding missing information, correcting factual errors, fixing typos, or bringing it up to date with the latest edge Rails. To get involved in the translation of Rails guides, please see [Translating Rails Guides](https://wiki.github.com/rails/docrails/translating-rails-guides).


Expand Down Expand Up @@ -258,10 +259,10 @@ more if the source code is mounted in `/vagrant` as happens in the recommended
workflow with the [rails-dev-box](https://github.com/rails/rails-dev-box). workflow with the [rails-dev-box](https://github.com/rails/rails-dev-box).


As a compromise, test what your code obviously affects, and if the change is As a compromise, test what your code obviously affects, and if the change is
not in railties run the whole test suite of the affected component. If all is not in railties, run the whole test suite of the affected component. If all
green that's enough to propose your contribution. We have [Travis CI](https://travis-ci.org/rails/rails) tests are passing, that's enough to propose your contribution. We have
as a safety net for catching unexpected breakages [Travis CI](https://travis-ci.org/rails/rails) as a safety net for catching
elsewhere. unexpected breakages elsewhere.


TIP: Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted. TIP: Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted.


Expand Down

0 comments on commit b9ead0f

Please sign in to comment.