Improve ActiveStorage analyzer error message for missing ffprobe. Add…

… mention to guides.
rails · Jan 7, 2022 · bc9060a · bc9060a
1 parent f2d9316
commit bc9060a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/activestorage/lib/active_storage/analyzer/audio_analyzer.rb b/activestorage/lib/active_storage/analyzer/audio_analyzer.rb
@@ -54,7 +54,7 @@ def probe_from(file)
           end
         end
       rescue Errno::ENOENT
-        logger.info "Skipping audio analysis because FFmpeg isn't installed"
+        logger.info "Skipping audio analysis because ffprobe isn't installed"
         {}
       end
 

diff --git a/activestorage/lib/active_storage/analyzer/video_analyzer.rb b/activestorage/lib/active_storage/analyzer/video_analyzer.rb
@@ -133,7 +133,7 @@ def probe_from(file)
           end
         end
       rescue Errno::ENOENT
-        logger.info "Skipping video analysis because FFmpeg isn't installed"
+        logger.info "Skipping video analysis because ffprobe isn't installed"
         {}
       end
 

diff --git a/guides/source/active_storage_overview.md b/guides/source/active_storage_overview.md
@@ -38,7 +38,7 @@ Various features of Active Storage depend on third-party software which Rails
 will not install, and must be installed separately:
 
 * [libvips](https://github.com/libvips/libvips) v8.6+ or [ImageMagick](https://imagemagick.org/index.php) for image analysis and transformations
-* [ffmpeg](http://ffmpeg.org/) v3.4+ for video/audio analysis and video previews
+* [ffmpeg](http://ffmpeg.org/) v3.4+ for video previews and ffprobe for video/audio analysis
 * [poppler](https://poppler.freedesktop.org/) or [muPDF](https://mupdf.com/) for PDF previews
 
 Image analysis and transformations also require the `image_processing` gem. Uncomment it in your `Gemfile`, or add it if necessary: