Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Eagerly validate pool arguments in Redis and MemCache stores
Fix: #48352 While we should ensure instantiating the store doesn't immediately attempt to connect, we should eagerly process arguments so that if they are somehow invalid we fail early during boot rather than at runtime. Additionally, since it's common to get pool parameters from environment variable, we can use `Integer` and `Float` so that string representations are valid.
- Loading branch information
Showing
5 changed files
with
77 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters