speed up fixture loading by querying the schema cache for column names

rails · Nov 26, 2012 · c99e34e · carlosantoniodasilva · Nov 26, 2012 · c99e34e
1 parent 4d0dc53
commit c99e34e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb
@@ -287,7 +287,7 @@ def reset_sequence!(table, column, sequence = nil)
       # Inserts the given fixture into the table. Overridden in adapters that require
       # something beyond a simple insert (eg. Oracle).
       def insert_fixture(fixture, table_name)
-        columns = Hash[columns(table_name).map { |c| [c.name, c] }]
+        columns = Hash[schema_cache.columns(table_name).map { |c| [c.name, c] }]
 
         key_list   = []
         value_list = fixture.map do |name, value|

diff --git a/activerecord/lib/active_record/connection_adapters/schema_cache.rb b/activerecord/lib/active_record/connection_adapters/schema_cache.rb
@@ -1,7 +1,7 @@
 module ActiveRecord
   module ConnectionAdapters
     class SchemaCache
-      attr_reader :columns, :columns_hash, :primary_keys, :tables, :version
+      attr_reader :columns_hash, :primary_keys, :tables, :version
       attr_accessor :connection
 
       def initialize(conn)
@@ -30,6 +30,15 @@ def add(table_name)
         end
       end
 
+      # Get the columns for a table
+      def columns(table = nil)
+        if table
+          @columns[table]
+        else
+          @columns
+        end
+      end
+
       # Clears out internal caches
       def clear!
         @columns.clear