Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Factor out valid_column_definition_options
Shopify is implementing a custom ActiveRecord adapter to integrate with [Vitess](https://vitess.io/), and we would like to overload the `valid_{column,table}_definition_options` methods and add additional valid options for schema migrations. For example: ```ruby module ActiveRecord module ConnectionAdapters class VitessMysql2Adapter < Mysql2Adapter ... def valid_table_definition_options super + [:skip_vschema_migrations, :sharding_keys, :auto_increment] end def valid_column_definition_options super + [:skip_vschema_migrations, :sharding_keys, :auto_increment] end end end end ``` This is the simplest possible change and factors out the various `valid_{table,column,primary_key}_definition_options` to be a public method on an adapter instance.
- Loading branch information