Skip to content

Commit

Permalink
It's snowing!
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremy committed Aug 12, 2010
1 parent 91ae6e9 commit e428300
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/helpers/form_tag_helper.rb
Expand Up @@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)

def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
:name => "utf8", :value => "✓".html_safe)
:name => "_utf8", :value => "☃".html_safe)

method = html_options.delete("method").to_s

Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_helper_test.rb
Expand Up @@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder

def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_tag_helper_test.rb
Expand Up @@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]

txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down

3 comments on commit e428300

@rickmzp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horray!

@collin
Copy link
Contributor

@collin collin commented on e428300 Aug 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I thought the checkmark was sensible, and actually indicates what it's doing a little bit.

I'd argue something more explicit like: _force_utf8=✓

Let's get our self-documentation on.

@taf2
Copy link

@taf2 taf2 commented on e428300 Aug 25, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the snow will be missed :(

Please sign in to comment.