javascript_tag should only concat when block_given?

rails · Jun 7, 2008 · e732a40 · e732a40
1 parent fec0f06
commit e732a40
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/actionpack/lib/action_view/helpers/javascript_helper.rb b/actionpack/lib/action_view/helpers/javascript_helper.rb
@@ -172,14 +172,17 @@ def escape_javascript(javascript)
       #     alert('All is good')
       #   <% end -%>
       def javascript_tag(content_or_options_with_block = nil, html_options = {}, &block)
-        if block_given?
+        content =
-          html_options = content_or_options_with_block if content_or_options_with_block.is_a?(Hash)
+          if block_given?
-          content = capture(&block)
+            html_options = content_or_options_with_block if content_or_options_with_block.is_a?(Hash)
-        else
+            capture(&block)
-          content = content_or_options_with_block
+          else
-        end
+            content_or_options_with_block
+          end
+
+        tag = content_tag("script", javascript_cdata_section(content), html_options.merge(:type => Mime::JS))
 
-        concat(content_tag("script", javascript_cdata_section(content), html_options.merge(:type => Mime::JS)))
+        block_given? ? concat(tag) : tag
       end
 
       def javascript_cdata_section(content) #:nodoc:

diff --git a/actionpack/test/template/javascript_helper_test.rb b/actionpack/test/template/javascript_helper_test.rb
@@ -82,8 +82,12 @@ def test_button_to_function_without_function
   end
 
   def test_javascript_tag
+    @output_buffer = 'foo'
+
     assert_dom_equal "<script type=\"text/javascript\">\n//<![CDATA[\nalert('hello')\n//]]>\n</script>",
       javascript_tag("alert('hello')")
+
+    assert_equal 'foo', @output_buffer, 'javascript_tag without a block should not concat to @output_buffer'
   end
 
   def test_javascript_tag_with_options