Skip to content

Commit

Permalink
Start Rails 5 development 🎉
Browse files Browse the repository at this point in the history
We will support only Ruby >= 2.1.

But right now we don't accept pull requests with syntax changes to drop
support to Ruby 1.9.
  • Loading branch information
rafaelfranca committed Nov 28, 2014
1 parent ee614af commit f25ad07
Show file tree
Hide file tree
Showing 20 changed files with 37 additions and 2,746 deletions.
6 changes: 0 additions & 6 deletions .travis.yml
Expand Up @@ -16,18 +16,12 @@ env:
- "GEM=ar:postgresql" - "GEM=ar:postgresql"
- "GEM=aj:integration" - "GEM=aj:integration"
rvm: rvm:
- 1.9.3
- 2.0.0
- 2.1 - 2.1
- ruby-head - ruby-head
- rbx-2 - rbx-2
- jruby - jruby
matrix: matrix:
allow_failures: allow_failures:
- rvm: 1.9.3
env: "GEM=ar:mysql"
- rvm: 2.0.0
env: "GEM=ar:mysql"
- rvm: ruby-head - rvm: ruby-head
env: "GEM=ar:mysql" env: "GEM=ar:mysql"
- rvm: rbx-2 - rvm: rbx-2
Expand Down
2 changes: 1 addition & 1 deletion RAILS_VERSION
@@ -1 +1 @@
4.2.0.beta4 5.0.0.alpha
64 changes: 1 addition & 63 deletions actionmailer/CHANGELOG.md
@@ -1,63 +1 @@
* `MailerGenerator` now generates layouts by default. The HTML mailer layout Please check [4-2-stable](https://github.com/rails/rails/blob/4-2-stable/actionmailer/CHANGELOG.md) for previous changes.
now includes `<html>` and `<body>` tags which improve the spam rating in
some spam detection engines. Mailers now inherit from `ApplicationMailer`
which sets the default layout.

*Andy Jeffries*

* `link_to` and `url_for` now generate URLs by default in templates.
Passing `only_path: false` is no longer needed.

Fixes #16497 and #16589.

*Xavier Noria*, *Richard Schneeman*

* Attachments can now be added while rendering the mail template.

Fixes #16974.

*Christian Felder*

* Add `#deliver_later` and `#deliver_now` methods and deprecate `#deliver` in
favor of `#deliver_now`. `#deliver_later` will enqueue a job to render and
deliver the mail instead of delivering it immediately. The job is enqueued
using the new Active Job framework in Rails and will use the queue that you
have configured in Rails.

*DHH*, *Abdelkader Boudih*, *Cristian Bica*

* `ActionMailer::Previews` are now class methods instead of instance methods.

*Cristian Bica*

* Deprecate `*_path` helpers in email views. They generated broken links in
email views and were not the intention of most developers. The `*_url`
helper is recommended instead.

*Richard Schneeman*

* Raise an exception when attachments are added after `mail` is called.
This is a safeguard to prevent invalid emails.

Fixes #16163.

*Yves Senn*

* Add `config.action_mailer.show_previews` configuration option.

This configuration option can be used to enable the mail preview in
environments other than development (such as staging).

Defaults to `true` in development and `false` elsewhere.

*Leonard Garvey*

* Allow preview interceptors to be registered through
`config.action_mailer.preview_interceptors`.

See #15739.

*Yves Senn*

Please check [4-1-stable](https://github.com/rails/rails/blob/4-1-stable/actionmailer/CHANGELOG.md)
for previous changes.
6 changes: 3 additions & 3 deletions actionmailer/lib/action_mailer/gem_version.rb
Expand Up @@ -5,10 +5,10 @@ def self.gem_version
end end


module VERSION module VERSION
MAJOR = 4 MAJOR = 5
MINOR = 2 MINOR = 0
TINY = 0 TINY = 0
PRE = "beta4" PRE = "alpha"


STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".") STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
end end
Expand Down

80 comments on commit f25ad07

@softr8
Copy link

@softr8 softr8 commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@anitviec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@anilreddy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@ferdinandrosario
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Awesome work. Thanks to the contributors....

@jogam5
Copy link

@jogam5 jogam5 commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@dtinth
Copy link

@dtinth dtinth commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@facundofarias
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nchelluri
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious... if the plan is to support Ruby versions >= 2.1, why not accept PRs with syntax changes that break in 1.9? Is this because you are not yet certain you will enforce the 2.1+ requirement and want the chance to revisit the decision?

@csaura
Copy link

@csaura csaura commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@imogenkinsman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorbypuff

@seuros
Copy link
Member

@seuros seuros commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchelluri :
We still are too close to 4.2 code and we are still in the release candidate. Right now we are not going to apply any change to remove compatibility to Ruby < 2.1 because it may make harder to backport things. -Rafael Mendonça França 2014-

@hafizio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@methyl
Copy link
Contributor

@methyl methyl commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@guyisra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any roadmap features?

@huobazi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顶!

@tibastral
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 Génial !!!!

@idanci
Copy link

@idanci idanci commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chareice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

楼主说得好啊,我顶啊。

@mikecarroll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@kahwee
Copy link

@kahwee kahwee commented on f25ad07 Nov 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NouranMahmoud
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nsinenko
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alexanderGugel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidcunha
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@gamafranco
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put pastéis de nata for everyone on my bill.

@marcamillion
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@george-carlin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@SunnyLi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dplord
Copy link

@dplord dplord commented on f25ad07 Nov 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
😺

@giedriusr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saboyutaka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@lucascaton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 😄

@duduribeiro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@simonewebdesign
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

@jnx
Copy link

@jnx jnx commented on f25ad07 Dec 4, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay :)

@Saidbek
Copy link

@Saidbek Saidbek commented on f25ad07 Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@fillman
Copy link
Contributor

@fillman fillman commented on f25ad07 Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pcofilada
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@icortex
Copy link

@icortex icortex commented on f25ad07 Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@tiegz
Copy link
Contributor

@tiegz tiegz commented on f25ad07 Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘 🤘

@cseeger
Copy link

@cseeger cseeger commented on f25ad07 Dec 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swoon 😍

@danjesus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@upstarter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚆 ❤️

@acrogenesis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@joaomilho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| - Gemfile
| + package.json

1, 2, 3... fight!

@sachatech
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that Rails 5 will target Ruby 2.2 for improved symbol GC?

@sachatech
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should have read the other posts first.

@luckydev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@schaary
Copy link

@schaary schaary commented on f25ad07 Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danpariente
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@bshakr
Copy link

@bshakr bshakr commented on f25ad07 Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ankurgupta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited !!

@vforge
Copy link

@vforge vforge commented on f25ad07 Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@achempion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat

@0xDing
Copy link

@0xDing 0xDing commented on f25ad07 Dec 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool:smile:

@adityieldify
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff guys, love you all 👍

@wzywno
Copy link

@wzywno wzywno commented on f25ad07 Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any roadmap or its draft?

@enlyn
Copy link

@enlyn enlyn commented on f25ad07 Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simlegate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HatsuMora
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're waiting! (Y)

Please sign in to comment.