Skip to content

Commit

Permalink
Merge pull request #46311 from skipkayhil/fix-broadcast-silence-test
Browse files Browse the repository at this point in the history
Fix test where broadcaster doesn't define #silence
  • Loading branch information
byroot committed Oct 23, 2022
2 parents 76c48fb + ae52978 commit fe420c5
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions activesupport/test/broadcast_logger_test.rb
Expand Up @@ -74,6 +74,9 @@ class BroadcastLoggerTest < TestCase
test "#silence does not break custom loggers" do
new_logger = FakeLogger.new
custom_logger = CustomLogger.new
assert_respond_to new_logger, :silence
assert_not_respond_to custom_logger, :silence

custom_logger.extend(Logger.broadcast(new_logger))

custom_logger.silence do
Expand Down Expand Up @@ -115,8 +118,6 @@ class BroadcastLoggerTest < TestCase
end

class CustomLogger
include ActiveSupport::LoggerSilence

attr_reader :adds, :closed, :chevrons
attr_accessor :level, :progname, :formatter, :local_level

Expand Down Expand Up @@ -168,6 +169,11 @@ def close
end

class FakeLogger < CustomLogger
include ActiveSupport::LoggerSilence

# LoggerSilence includes LoggerThreadSafeLevel which defines these as
# methods, so we need to redefine them
attr_accessor :level, :local_level
end
end
end

0 comments on commit fe420c5

Please sign in to comment.