fix HashWithIndifferentAccess#to_hash behaviour #10266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,7 +229,11 @@ def to_options!; self end | |||
|
|
|||
| # Convert to a regular hash with string keys. | |||
| def to_hash | |||
| Hash.new(default).merge!(self) | |||
| _new_hash= {} | |||
There was a problem hiding this comment.
Please suggest on a faster way to copy to a new hash if any.
There was a problem hiding this comment.
I think this is the best one
|
Could you add a test case? |
|
adding |
|
added |
|
@rafaelfranca anything else, I should update? |
|
@rafaelfranca 1 month ping. Anything else this needs to handle? |
rafaelfranca
added a commit
that referenced
this pull request
May 14, 2013
fix HashWithIndifferentAccess#to_hash behaviour
|
Hmm, seems a bit counterintuitive to me - the method isn't called e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
HashWithIndifferentAccess#to_hash,returns a hash containing HashWithIndifferentAccess within for a nested hash, egif
{:a => {:b => {:c => '3'}}}is a HashWithIndifferentAccessthen #to_hash returns
{:a => {:b => {:c => '3'}}}where {:b => {:c => '3'}} is a
HashWithIndifferentAccessobject, while the whole object itself is aHash