refactor initialization of array

[vipulnsward]

refactor statements

[dmathieu]

This is only a cosmetic change. Those aren't usually merged, sorry.

[vipulnsward]

How is this cosmetic? Its a bit faster, losing 2 operations.

[vipulnsward]

@dmathieu just for ref: https://gist.github.com/vipulnsward/768bcf54ed67dbac4b06
It would be fine if this gets rejected to maintain code-style maybe.

[dmathieu]

I don't think this kind of micro optimization is worth the change. It really has a very small impact.

[siong1987]

require "benchmark"

Benchmark.bm(7) do |x|
  x.report("before:")   do
    (1..100000).each do
      method = []
      method << "value = nil"
      method << "halted = false"
    end
  end
  x.report("after:") do
    (1..100000).each do
      method =  ["value = nil", "halted = false"]
    end
  end
end

              user     system      total        real
before:   0.090000   0.000000   0.090000 (  0.092787)
after:    0.080000   0.000000   0.080000 (  0.078116)

You are right. But, it seems like it also makes the code cleaner. Not worth a huge debate over it tho.