Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized column should not be wrapped twice. Fix #10067. #10330

Merged
merged 2 commits into from Apr 24, 2013

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Apr 24, 2013

See #10067

If AR's instance has serialized attribute ( or timezone aware attribute), instance level @columns_hash is wrapped multiple times during instantiate in current implementation.

@rafaelfranca
Copy link
Member

@kennyj could you add a CHANGELOG entry with a description of the problem?

@rafaelfranca
Copy link
Member

Also I think we should call the dup inside the instantiate metod like was did at #10067 (methods should not mutate their arguments)

@kennyj
Copy link
Contributor Author

kennyj commented Apr 24, 2013

ok. just a moment.

@mdespuits
Copy link

Looks like there are some dupicate commits from master.

@kennyj
Copy link
Contributor Author

kennyj commented Apr 24, 2013

@mattdbridges thanks for reporting. I've update this PR aginn. Is this ok ?
@rafaelfranca I've update this PR.

@mdespuits
Copy link

@kennyj Looks like 2461deb4 is the only one still dangling. Can you squash your commits?

@kennyj
Copy link
Contributor Author

kennyj commented Apr 24, 2013

I've updated again.
@mattdbridges I'm afraid that disappearing @derikson 's contribution. so I've squashed my commits only.

@mdespuits
Copy link

@kennyj Gotcha. Looks good to me

rafaelfranca added a commit that referenced this pull request Apr 24, 2013
Serialized column should not be wrapped twice. Fix #10067.
@rafaelfranca rafaelfranca merged commit 4e3eca4 into rails:master Apr 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants